Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate TacoApplication and Dockerize Development #603

Closed
wants to merge 22 commits into from

Conversation

theref
Copy link
Member

@theref theref commented Sep 1, 2023

No description provided.

@theref theref changed the title Replace pre with taco WIP: Replace pre with taco Sep 1, 2023
@theref theref marked this pull request as draft September 1, 2023 13:33
@theref theref changed the title WIP: Replace pre with taco Replace pre with taco Sep 11, 2023
@theref theref marked this pull request as ready for review September 11, 2023 12:01
Copy link
Contributor

@arjunhassard arjunhassard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

src/pages/Staking/HowItWorks/StakingApplications/index.tsx Outdated Show resolved Hide resolved
src/pages/Staking/HowItWorks/StakingApplications/index.tsx Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/enums/externalHref.ts Outdated Show resolved Hide resolved
}),
[stakeAmount, tacoMinAuthAmount]
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a warning modal at some point before authorizing is complete that informs the staker of the Deauthorization Delay:

The deauthorization delay is the time one must wait between initiating a withdrawal from TACo service provision and being able to complete that withdrawal. The deauthorization delay for TACo currently set to 6 months (183 days). Note that this is 138 days longer than tBTC and Random Beacon (45 days).

And a link to the Duties & Compensation page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might even be a good idea to get stakers to tick a box saying they understand. It doesn't mean anything legally, but it means they're less likely to skip through the warning without reading it.

@@ -17,6 +17,10 @@ const iconMap: Record<StakingAppName, Record<Operation, string>> = {
increase: randomBeaconIncrease,
decrease: randomBeaconDecrease,
},
taco: {
increase: tbtcIncrease,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we at the very least copy the same image and rename to tacoIncrease/Decrease...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New image is required. It looks like this:

image

@KPrasch KPrasch changed the title Replace pre with taco Dockerize evelopment and Replace "pre" with "taco" Sep 18, 2023
@KPrasch KPrasch changed the title Dockerize evelopment and Replace "pre" with "taco" Dockerize Development and Replace "pre" with "taco" Sep 18, 2023
@KPrasch KPrasch changed the title Dockerize Development and Replace "pre" with "taco" Integrate TacoApplication and Dockerize Development Sep 18, 2023
…lect local filesystem changes during development

Co-authored-by: James Campbell <[email protected]>
@theref
Copy link
Member Author

theref commented Sep 23, 2023

Closing, replaced by #625 and #624

@theref theref closed this Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants